search

RPi-Distro / rpi-source

Raspberry Pi kernel source installer
MIT License
140 stars 39 forks source link

Add support for Bookworm #23

Closed Jason3-14Butler closed 11 months ago

Jason3-14Butler commented 11 months ago

Bookworm moved the path of the firmware directory. Consequently the script fails on Bookworm. This patch parameterizes the firmware version path and checks the Raspbian version so that the correct firmware version path is used.

pelwell commented 11 months ago

I have a few comments:

  1. It's not "Rasbian", it's "Raspbian".
  2. Our OS isn't called "Raspbian", it's called "Raspberry Pi OS".
  3. Naming aside, this looks as though it ought to work, but it seems like a sledgehammer to crack a nut. A simpler patch would be to check for the new /boot/firmware/.firmware_version first, falling back to the old path if it isn't found. rpi-update (a bash script) uses: 
    if mountpoint -q /boot/firmware ; then
    BOOT_PATH=${BOOT_PATH:-"/boot/firmware"}
else
    BOOT_PATH=${BOOT_PATH:-"/boot"}
fi
pelwell commented 11 months ago

Superseded by #24.