RRFSx / rrfs-workflow_beta

GNU Lesser General Public License v3.0
0 stars 5 forks source link

update documents #52

Closed guoqing-noaa closed 4 months ago

guoqing-noaa commented 4 months ago

Hi all, if you have time, please take a look at the updated build_and_run.md: https://github.com/guoqing-noaa/rrfs-workflow/blob/doc/docs/build_and_run.md

Let me know if there is anything not clear. Thanks!

EricJames-NOAA commented 4 months ago

@guoqing-noaa I have been working through it in the background today! I will let you know if I find any issues.

guoqing-noaa commented 4 months ago

Thanks, @EricJames-NOAA

EricJames-NOAA commented 4 months ago

Thanks, @EricJames-NOAA

@guoqing-noaa I'm having trouble with this step:

./setup_exp.py exp/exp_setup

In the previous step, we copied exp_setup to the workflow/ directory, so shouldn't it be:

./setup_exp.py exp_setup

But I can't get that to work either:

[Eric.James@fe7 workflow]$ ./setup_exp.py exp_setup Traceback (most recent call last): File "./setup_exp.py", line 20, in source(fpath) File "/mnt/lfs4/BMC/wrfruc/ejames/coding/rrfs-workflow/workflow/xml_funcs/base.py", line 22, in source raise Exception(f"Error sourcing bash file: {stderr}") Exception: Error sourcing bash file: bash: exp_setup: No such file or directory

Maybe something is missing in my environment.

guoqing-noaa commented 4 months ago

Thanks, @EricJames-NOAA This PR is to correct outdated information in the repo, such as ./setup_exp.py exp/exp_setup you mentioned.

It should be ./setup_exp.py exp.setup. Sorry about that.

guoqing-noaa commented 4 months ago

@EricJames-NOAA , could you follow my updated instructions here: https://github.com/guoqing-noaa/rrfs-workflow/blob/doc/docs/build_and_run.md

Thanks!

guoqing-noaa commented 4 months ago

@EricJames-NOAA I think I inherited the typo even in my updated instructions. I just corrected it.

Thanks a lot for testing. It looks like specifying exp.setup should be optional so as to improve user experiences. I will create a PR to make this happen.

EricJames-NOAA commented 4 months ago

@EricJames-NOAA I think I inherited the typo even in my updated instructions. I just corrected it.

Thanks a lot for testing. It looks like specifying exp.setup should be optional so as to improve user experiences. I will create a PR to make this happen.

@guoqing-noaa thanks! It seems to be working now! I am able to submit the XML and get jobs in the queue.

I'll try to get to the UPP step so I can easily test UPP modifications

guoqing-noaa commented 4 months ago

Great. Thanks, @EricJames-NOAA Do you test on Hera or Jet?

EricJames-NOAA commented 4 months ago

Great. Thanks, @EricJames-NOAA Do you test on Hera or Jet?

@guoqing-noaa on Jet.

guoqing-noaa commented 4 months ago

OK, now users can run setup_exp.py without the need to specify a command line option.