search

RROrg / rr

Redpill Recovery (arpl-i18n)
GNU General Public License v3.0
4.91k stars 832 forks source link

BUG PhotoFace-Patch #4256

Closed MartinKuhl closed 1 week ago

MartinKuhl commented 4 weeks ago

Install ENV:

CPU: Intel Atom NIC: SKY2 RR version: latest 24.10.3

DSM:

model: 3622xs+ version: 7.2.1 Patch 5

Issue:

The PhotoFace-Patch is not enabling the face recognition in DSM. All tries to recognize the faces ending in timeouts. If I directly execute the patch from here: https://github.com/jinlife/Synology_Photos_Face_Patch/blob/main/bin/patch.sh it is directly working. Is there a special order how to install the DSM Photo app and installing the patch from the loader after the DSM-app installation?

wjz304 commented 3 weeks ago

加载程序选则addon，启动DSM后安装 Photo ，重启DSM

MartinKuhl commented 3 weeks ago

I alreasy installed the addon but it isn't working

wjz304 commented 3 weeks ago

I tested it and found that there is a bug in the addon. Since Synology Photos is installed in the storage pool, the path where it is located will only exist after the application is started. And the addon is run too early, resulting in the path where the photos library does not exist during runtime.

wjz304 commented 3 weeks ago

This problem is currently difficult to solve.

MartinKuhl commented 3 weeks ago

Looks Like arc loader fixed this issue in one of the last updates. Just FYI maybe you can adopt this solution.

wjz304 commented 3 weeks ago

The changes of arc don't make sense, but I did find a solution.

wjz304 commented 3 weeks ago

https://github.com/RROrg/rr/releases/tag/24.11.0 test

AuxXxilium commented 3 weeks ago

The changes of arc don't make sense, but I did find a solution.

they make sense, because the load point of service was wrong: if we change it back toAfter=multi-user.target it is working like it should

wjz304 commented 3 weeks ago

The changes of arc don't make sense, but I did find a solution.

they make sense, because the load point of service was wrong: if we change it back toAfter=multi-user.target it is working like it should

Yes, but that's not strict, the photosfacepatch service should be run after the storage pool is loaded (theoretically, before the photo app is started).