Closed OoJJBoO closed 8 months ago
Looks good, thanks for your work on the comments.
I found a small error in the F90 interface. The function in likwid_f90_interface.c
has to have an underscore in the end: likwid_writemarkerfile_
.
Updated. Looking at the other functions in the same file, I guess I should probably also use the way of passing in the string argument's length and copying it first before passing it to the likwid_writeMarkerFile
function, right? Didn't notice that earlier for some reason.
Yes, you should copy the string before providing it to the C functions.
Okay, I changed it. I also added the missing register macro in the Lua bindings.
Sorry that I didn't check more thoroughly. I'm on a business trip (SC23) and read your code in between meetings. Next week I have more time to go through your changes.
No worries, take your time :)
I looked at your code again and I realized that the new functions/macros do not follow the current naming scheme:
likwid_writeMarkerFile
-> likwid_markerWriteFile
LIKWID_WRITE_MARKER_FILE
-> LIKWID_MARKER_WRITE
or LIKWID_MARKER_WRITE_FILE
likwid_writemarkerfile_
-> likwid_markerwritefile_
lua_likwid_writeMarkerFile
-> lua_likwid_markerWriteFile
Ah, I see, you're right. I'll update them soon
I think my last commit should have updated all function names accordingly.
Thanks, that should be all functions for the CPU MarkerAPI.
I should probably add similar functions for the Nvidia MarkerAPI and the ROCm MarkerAPI.
Add
likwid_writeMarkerFile
function to address the issue described in #583.