RRZE-HPC / likwid

Performance monitoring and benchmarking suite
https://hpc.fau.de/research/tools/likwid/
GNU General Public License v3.0
1.64k stars 226 forks source link

[BUG] LIKWID_NVMARKER* shortcuts are not working #590

Closed teojgo closed 8 months ago

teojgo commented 8 months ago

Describe the bug

The LIKWID_NVMARKER family of shortcuts (e.g LIKWID_NVMARKER_INIT) are not recognized. The following error is thrown during compilation:

tream.cu(150): error: identifier "likwid_gpuMarkerInit" is undefined

stream.cu(162): error: identifier "likwid_gpuMarkerRegisterRegion" is undefined

stream.cu(171): error: identifier "likwid_gpuMarkerStartRegion" is undefined

stream.cu(174): error: identifier "likwid_gpuMarkerStopRegion" is undefined

stream.cu(182): error: identifier "likwid_gpuMarkerStartRegion" is undefined

stream.cu(185): error: identifier "likwid_gpuMarkerStopRegion" is undefined

stream.cu(193): error: identifier "likwid_gpuMarkerStartRegion" is undefined

stream.cu(196): error: identifier "likwid_gpuMarkerStopRegion" is undefined

stream.cu(204): error: identifier "likwid_gpuMarkerStartRegion" is undefined

stream.cu(207): error: identifier "likwid_gpuMarkerStopRegion" is undefined

stream.cu(233): error: identifier "likwid_gpuMarkerClose" is undefined

To Reproduce It is straightforward to reproduce by trying to make one of the cuda related tests using: make -C tests streamCU

likwid was build with Nvidia integration enabled.

TomTheBear commented 8 months ago

Thanks for reporting. Another user @Atrisan found it yesterday and reported it in the LIKWID chat.

The patch is contained in #586 : https://github.com/RRZE-HPC/likwid/pull/586/files#diff-97290a617557f2326bf33082439592b0ab9a6dfae07b0a7453a06eddba50bc19

I have to do some testing before I can merge the PR #586, so feel free to use the patch.

TomTheBear commented 8 months ago

This should be now fixed and part of the master branch. It would be great if you could test it and comment on/close the issue.

teojgo commented 8 months ago

make -C tests streamCU

Yes now it works, thank you very much!