RRethy / base16-nvim

Neovim plugin for building a sync base16 colorscheme. Includes support for Treesitter and LSP highlight groups.
MIT License
523 stars 77 forks source link

Floating windows are indiscernible #101

Closed Ch00k closed 6 months ago

Ch00k commented 6 months ago
Screenshot 2024-05-22 at 08 03 41 Screenshot 2024-05-22 at 08 04 05

The floating windows from coc.nvim have the same background color as the main window, and no border, which makes them very difficult to read. It looks like #54 was an attempt to change that, but it was discarded. The comment in that PR mentions the "border option", however, when I make the following change, I see no difference. It looks like the floating windows have no border at all.

- hi.FloatBorder = { guifg = M.colors.base05, guibg = M.colors.base00, gui = nil, guisp = nil }
+ hi.FloatBorder = { guifg = M.colors.base05, guibg = M.colors.base01, gui = nil, guisp = nil }

Is there a reason to not change the value of NormalFloat, so that the floating window background is different from the main window? If so, what would be the best way to have the floating window stand out a bit more?

RRethy commented 6 months ago

Borders would be what I recommend.

image

You can override that highlight group in your own config if you want to change it.

Ch00k commented 6 months ago

@RRethy thank you for the tip. I am not very familiar with Vim UI elements and color scheme stuff. Would you mind giving an example of what I should do to enable those borders in my config?

Ch00k commented 5 months ago

I found out that you can add a border to coc.nvim floating windows by adding "diagnostic.floatConfig.border": true to coc.nvim config file (more info in coc-config-float section of coc.nvim docs). Look a little better now.

Screenshot 2024-05-29 at 14 26 59