search

RRethy / base16-nvim

Neovim plugin for building a sync base16 colorscheme. Includes support for Treesitter and LSP highlight groups.
MIT License
502 stars 76 forks source link

Add to official base16 scheme list #27

Open augustebaum opened 2 years ago

augustebaum commented 2 years ago

Hi,

If it's not already in the plans, consider adding this to the list of schemes.

Nice work!

RRethy commented 2 years ago

I'm not sure we would be allowed since this repo doesn't actually follow some of their guidelines. The repo name and the fact we don't look at the terminals 16 colours are the main areas we break their guidelines.

augustebaum commented 2 years ago

Is this something you intend to work towards? Otherwise, would forking be acceptable?

RRethy commented 2 years ago

I'm open to PRs to add 16 terminal colour support, it would actually fix the other issue in this repo https://github.com/RRethy/nvim-base16/issues/18. I'm a bit busy right now with personal life and moving so I won't have time to implement this but near the end of november things should clear up and I can try to implement the changes. I'd be open to renaming this repo to base16-nvim to match the style guide from base 16.

EtiamNullam commented 2 years ago

@RRethy: I believe GitHub will still redirect from old link so changing repository name should be painless. At least that was the case for one of plugins I was using that also changed name.

More info: https://docs.github.com/en/repositories/creating-and-managing-repositories/renaming-a-repository

RRethy commented 2 years ago

Yup, renaming isn't a issue, the main issue is the 16 terminal colour support to make it eligible for that scheme list. This isn't super high on my priority list because most people (including myself) just use true colours.