RRethy / base16-nvim

Neovim plugin for building a sync base16 colorscheme. Includes support for Treesitter and LSP highlight groups.
MIT License
523 stars 77 forks source link

Some bad highlightings when tree-sitter is on #68

Closed ali-githb closed 1 year ago

ali-githb commented 1 year ago

I've been using this plugin for a while now and I'm very grateful for that. However I noticed some issues with the highlighting when tree-sitter is on. I am using neovim 0.8.1. There are those 3 that I have in mind (with screenshots, first with tree-sitter on then with tree-sitter off) :

Screenshot from 2023-01-12 17-57-20

Screenshot from 2023-01-12 17-56-38

Screenshot from 2023-01-12 18-01-59

Screenshot from 2023-01-12 18-00-56

Screenshot from 2023-01-12 17-58-56

Screenshot from 2023-01-12 17-59-39

For the moment I use this workaround for the first two issues (in case someone is interested : vim.api.nvim_set_hl(0, "@tag", { link = "Identifier" }) vim.api.nvim_set_hl(0, "@type.qualifier", { link = "Keyword" })

I have not found a good workaround for the third one yet. It would be nice if those things were handled by the colorscheme itself. Thanks again for your work !

EDIT: I created a pull request that solves this issue (It might not be the best way to do it, I'm really no expert on that subject but I thought I would give it a try).