search

RRethy / vim-illuminate

illuminate.vim - (Neo)Vim plugin for automatically highlighting other uses of the word under the cursor using either LSP, Tree-sitter, or regex matching.
2.19k stars 50 forks source link

Use CursorWorld highlighting group #128

Closed Shatur closed 2 years ago

Shatur commented 2 years ago

I would like to suggest to add CursorWord, CursorWord0 and CursorWord1 and fallback to them from Illuminated* highlights. Many colorschemes use them, it would simplify like for colorscheme developers.

RRethy commented 2 years ago

I don't see many colorschemes using those highlights (I looked at 15 repos), the only one was sonokai which also specifies the vim-illuminate highlight groups anyways.

As for the highlight groups themselves, they are not documented in the plugin I'm assuming you found them from vim-cursorword, their behaviour is not specified, only their name is mentioned briefly.

I'm not going to add unnecessary complexity to have compatibility with a lesser used Vim plugin that uses cryptic highlight group names which lack documentation.

Shatur commented 2 years ago

I don't see many colorschemes using those highlights (I looked at 15 repos)

Hm... Strange, I assumed it used more often.

I'm assuming you found them from vim-cursorword

The group CursorWorld is also used here. But I see your point. Names Illuminated* just unique and it forces colorscheme authors to add more highlighting groups.