search

RRethy / vim-illuminate

illuminate.vim - (Neo)Vim plugin for automatically highlighting other uses of the word under the cursor using either LSP, Tree-sitter, or regex matching.
2.12k stars 44 forks source link

Highlight changed from illumated background to underline #138

Closed OlegGulevskyy closed 1 year ago

OlegGulevskyy commented 1 year ago

Describe the bug Before I moved from 0.7 to 0.8, I had illuminate highlighted in a nice way

image

Now it's just underlined like so

image

To Reproduce Use neovim 0.8, I guess ? I am not sure if I am the only one affected, or if I am overwriting something accidentally

Output from :IlluminateDebug

buf_should_illuminate 11 true
config {
  delay = 100,
  filetype_overrides = {},
  filetypes_allowlist = {},
  filetypes_denylist = { "dirbuf", "dirvish", "fugitive" },
  modes_allowlist = {},
  modes_denylist = {},
  providers = { "lsp", "treesitter", "regex" },
  providers_regex_syntax_allowlist = {},
  providers_regex_syntax_denylist = {},
  under_cursor = true
}
started true
provider table: 0x0109490088 lsp

Expected behavior Highlighted as before, in a nice "illuminated" way

Allaman commented 1 year ago

Hmm I don't think that is Neovim 0.8 related. It is just the new default highlighting of vim-illuminate. Please refer to https://github.com/RRethy/vim-illuminate/issues/115, I guess that should help you

RRethy commented 1 year ago

As @Allaman mentioned, it's related to https://github.com/RRethy/vim-illuminate/issues/111, you'll need to define IlluminatedWordText, IlluminatedWordRead, IlluminatedWordWrite highlight groups (default to underline).

OlegGulevskyy commented 1 year ago

Thanks for the pointer, indeed that's the change. I was wondering though why this was changed to underline by default, as to me this makes little sense - it was highlighting it the way you'd expect a package called "illuminate", so it's illuminating words :)