search

RReverser / serde-xml-rs

xml-rs based deserializer for Serde (compatible with 1.0+)
https://crates.io/crates/serde-xml-rs
MIT License
269 stars 90 forks source link

Draft: fix nested vec serialization #199

Open julienr opened 1 year ago

julienr commented 1 year ago

This is an attempt at fixing #186 . Although the fix seems to work, I haven't fully understood why and so I'm not sure if it's the right fix or not.

I feel some additional serialization test cases should be added to robustify this part.

LukeSkyw commented 1 year ago

@RReverser do you think @julienr fix is OK?

christopher-drews commented 1 year ago

I have the same issue like in #186. The fix from @julienr also works great for me. Would be awesome if this could be released soon. Please let me know if I can support to speed things up.

julienr commented 1 year ago

I moved to a custom serializer for other reasons, so pushing my fix isn't a priority for me. But if someone wants to test and summit it, go ahead.

On Tue, Apr 25, 2023, 13:32 Christopher Drews @.***> wrote:

I have the same issue like in #186 https://github.com/RReverser/serde-xml-rs/issues/186. The fix from @julienr https://github.com/julienr also works great for me. Would be awesome if this could be released soon. Please let me know if I can support to speed things up.

— Reply to this email directly, view it on GitHub https://github.com/RReverser/serde-xml-rs/pull/199#issuecomment-1521634735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD3V2TFWUIDRAZ6K4NOCPTXC6Y5RANCNFSM6AAAAAAVPO5ERE . You are receiving this because you were mentioned.Message ID: @.***>

RReverser commented 1 year ago

Sorry, but I gave rights to @punkstarman to maintain this repo a while ago.

LukeSkyw commented 1 year ago

See quick_xml