search

RS-DAT / JupyterDaskOnSLURM

Apache License 2.0
16 stars 3 forks source link

Bash spider containerization #70

Closed meiertgrootes closed 3 months ago

meiertgrootes commented 3 months ago

provides bash install/containerization for spider hiding setup from users. Completes #69

execute as bash spider_container_deploy.sh

Note: Users are now first required to manually clone JupyterDaskOnSlurm in order to have access to the script. This is reflected in the updated user guide.

rogerkuou commented 3 months ago

Hi @meiertgrootes, sorry for waiting so long on review this!

I have tested the bash script with two PhDs, it works like a charm. The only hiccup came from a typo I introduced in the example SLURM scripts, which prevented your bash from updating it. I fixed it in this commit.

Only one comment on removing a commented-out command. I suggest to remove it. Feel free to merge!