Added the lit Braziers in Wintertodt as a light source

[Ben10164]

Working code that implements the feature I proposed in https://github.com/RS117/RLHD/issues/308#issue-1244055520!

With/Without

"Flicker" effect

Added the Lit Brazier to lights.json

  {
    "description": "WINTERTODT_LIT_BRAZIER",
    "height": 300,
    "alignment": "CENTER",
    "radius": 600,
    "strength": 15,
    "color": [
        165,
        255,
        56
    ],
    "type": "FLICKER",
    "duration": 0,
    "range": 15,
    "objectIds": [
        "BURNING_BRAZIER_29314",
        "BURNING_BRAZIER_31926"
    ]
  },

https://github.com/Ben10164/RLHD/blob/9cb635344aa8b423caefeb6bef441d70684727f7/src/main/resources/rs117/hd/scene/lighting/lights.json#L29331-L29349

As well as moving the Doors of Dihn down to follow the Lit Brazier

  {
    "description": "WINTERTODT_DOOR",
    "height": 500,
    "alignment": "SOUTH",
    "radius": 1500,
    "strength": 15,
    "color": [
        165,
        255,
        56
    ],
    "type": "STATIC",
    "duration": 0,
    "range": 0,
    "objectIds": [
        "DOORS_OF_DINH"
    ]
  }

https://github.com/Ben10164/RLHD/blob/9cb635344aa8b423caefeb6bef441d70684727f7/src/main/resources/rs117/hd/scene/lighting/lights.json#L29350-L29367

[xxEzri]

I'l take a look at this ingame, some quick thoughts for now:

I expect that trading some strength for radius (e.g. 600 radius, 15 str) would look better - it's a good rule to make radius at least around twice of the height, so that the light hits the floor properly and you don't have to overstrengthen it.

As the flicker range is proportional to radius, that would also be lowered by the same factor that radius was increased (1.333x) to keep the same look, which would put it at 15. I think further adjustment down from there might look nicer tho.

Is the light only on when the Brazier is lit?

Good to see more people around, hop in the dev channel on discord sometime (:

[Ben10164]

I expect that trading some strength for radius (e.g. 600 radius, 15 str) would look better - it's a good rule to make radius at least around twice of the height, so that the light hits the floor properly and you don't have to overstrengthen it.

I'll get started on a new commit! I was confused on how to find a proper value for height.

Is the light only on when the Brazier is lit?

Yes it is! It's only for the IDs of the lot Brazier. I should've added a gif showing that!

Good to see more people around, hop in the dev channel on discord sometime (:

I was there earlier getting some help compiling, but I'll be more active!

[sosodev]

Nice work!