search

RS117 / RLHD

BSD 2-Clause "Simplified" License
150 stars 62 forks source link

Baked lights Changes #311

Closed Mark7625 closed 2 years ago

Mark7625 commented 2 years ago

Added A baked Light id and Magic Carpet Fix

sosodev commented 2 years ago

We don't need to copy the item ID definitions here because they're only needed at compile time

Mark7625 commented 2 years ago

We don't need to copy the item ID definitions here because they're only needed at compile time

We need them for compile time tho? Since they are used for carpets?

sosodev commented 2 years ago

The compiler will substitute ItemID.MAGIC_CARPET with the actual ID during compilation. We needed to copy the other IDs so we could lookup the IDs for the enum values that we have in the JSON at runtime.

Mark7625 commented 2 years ago

Ah didn't think it did that, fair enough I'll remove it now