search

RS117 / RLHD

BSD 2-Clause "Simplified" License
150 stars 62 forks source link

Fix kernel loading on mac #315

Closed testing-ongithub closed 2 years ago

testing-ongithub commented 2 years ago

Master currently doesn't run on mac. This fixes that.

sosodev commented 2 years ago

Thanks for the PR @testing-ongithub

I don't think we should move these files out of the resources directory. We should instead fix the lookup to look in the right spot. We can simply the use the main hd plugin class for the lookup.

Mark7625 commented 2 years ago

I have a pr that fixes all of this and does correct lookups just need to tidy it up

testing-ongithub commented 2 years ago

Thanks for the PR @testing-ongithub

I don't think we should move these files out of the resources directory. We should instead fix the lookup to look in the right spot. We can simply the use the main hd plugin class for the lookup.

What do you mean? They're still in the resources directory. They're now just in the resources folder for the class that addIncludes them. https://github.com/RS117/RLHD/blob/master/src/main/java/rs117/hd/opengl/compute/OpenCLManager.java#L402

sosodev commented 2 years ago

Sorry, I must have misread the diff :smile: