Bump gradle version to 7.4

RS117 / RLHD

BSD 2-Clause "Simplified" License

150 stars 62 forks source link

Closed testing-ongithub closed 2 years ago

testing-ongithub commented 2 years ago

For three reasons:

for consistency with https://github.com/runelite/example-plugin/commit/dc2102c
to allow the plugin to build with JDK 17
to make it so I don't need to keep making this change locally whenever I make/pull a new branch

Reasons 2 and 3 go together. I hadn't noticed Reason 1 until now, which is why I didn't make this PR earlier. 😅

sosodev commented 2 years ago

Are you sure that's the right gradle-wrapper jar? The wrapper jar from the 7.4 distribution zip has a different sha256

aHooder commented 2 years ago

Checks out with the hash for v7.4.2 displayed here on my end

sosodev commented 2 years ago

Indeed it does :+1: I guess the one in the distribution zip is just slightly different for whatever reason

aHooder commented 2 years ago

Yeah, who knows why :shrug:. I'm happy to see that you're checking this sort of thing :slightly_smiling_face:

Mark7625 commented 2 years ago

Indeed it does 👍 I guess the one in the distribution zip is just slightly different for whatever reason

Sometimes Intellij Caches it and u have to revalidate your caches and reload, I had the issue a few times on other Projects