ThaumCraft Aspects not rendering on the Request UIs

[Bernasss12]

While on the Request Pipe's GUI when you shift hover over an item it shows the extra tooltip but it seems to add two extra empty lines, easier to show than to tell: -Diamond block has no extra tooltip information so if only shows two empty lines: -Provider Logistics Pipes has information to show but also has two empty lines after said information is shown:

[hron84]

A random idea, but it seems like you lacking to use a mod that adds the mod name to items, like HWYLA or Mod Name Tooltip. I bet this causes the empty lines for you. Could you try out one of them and check if the empty lines are still present?

Also could you please include LP and Forge versions into your issue report? There is two different version of LP (one for 1.7.10 one for 1.12.2) and based on a screenshot it's quite hard to determine what version is affected in this bug.

[Bernasss12]

I could and maybe will indeed check if that makes any difference The version I'm using is the dev version, I mainly created this issue to remind myself (and others) to take a look at this

[hron84]

It's cool to make reminders but I bet you will totally forget which versions did you use after a few weeks. Also if someone want to jump into this issue, he/she would want to re-create the environment to reproduce the issue, versions are important for this. Maybe you can get a solution earlier than you could get a time for fix it! 😄

[bziemons]

Well, if he wasn't also developing, I would totally agree @hron84 :) But I basically told him to make an issue, if he thinks it is an issue (instead of adding a TODO comment in the source code). Saying whether this occurs on 1.12 or 1.7.10 isn't necessary anymore. We are working on 1.12 only.

[davboecki]

@Bernasss12 Is Thaumcraft installed when the additional two lines appear?

[Bernasss12]

Yes it was, I was using the development environment. And I was already pretty sure the problem wasn't from logistics pipes since I tried to find it with no luck. Now that you've mentioned thaumcraft I'm sure this isn't LP's problem and the issue can be closed

[davboecki]

I think this is not really a problem but rather a side effect or missing interaction depending on how you look at it. I think it is Thaumcraft adding two empty lines to that they later can render their aspects over the tooltip to make it look like they are inside the tooltip.

[Bernasss12]

I had no idea that was the way the made that but that's actually pretty smart, and yes in that case it's not a big at all even if the aspects are not being shown, I guess now I will try to make them show instead of removing the empty lines.

On Thu, 13 Jun 2019, 13:29 davboecki, notifications@github.com wrote:

I think this is not really a problem but rather a side effect or missing interaction depending on how you look at it. I think it is Thaumcraft adding two empty lines to that they later can render their aspects over the tooltip to make it look like they are inside the tooltip.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RS485/LogisticsPipes/issues/1224?email_source=notifications&email_token=ABPR3HCDTNROCY3URANKTI3P2I4RVA5CNFSM4HQEUNO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTQ4II#issuecomment-501681697, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPR3HGQDUVHLRE5OA7CRMTP2I4RVANCNFSM4HQEUNOQ .

[bziemons]

What's the status on this @Bernasss12 ? I haven't been able to reproduce the issue.

[Bernasss12]

I can still reproduce the bug in the most up-to-date branch:

In the Request Table the bug only happens in half the slots:

Request Table Images

_Right side of the table_  _Left side of the table_  _Table with slots that work outlined green , and the ones that don't outlines red_ 

The Request Pipe's GUI has the problem in every slot:

Request Pipe Images

_Request Pipe MK1_  _Request Pipe MK2_ 

The Add Macro Popup has the same problem:

Request Table Add Macro Images

_Add Macro Popup_ 

The statistics table, while choosing which item to track:

Statistics Table Images

_Gui Statistics_ 

Possible solution

While investigating and trying to solve the issue I got to the conclusion that the way LP is drawing the tooltips is going over one of the Events that the normal tooltips go through, and that Event is what triggers the default ThaumCraft Aspect Rendering Iirc the Event was called something along the lines RenderToolTipEvent.PostText

The problem I encountered while trying to find a solution myself was that a weird rendering clipping was happening, the aspects where being overlapped by the drawn items behind them:

Statistics Table Images

_Don't know how well you can see that but here it is_ 

[Bernasss12]

I also checked with Logistics Pipes version LP0.10.2.195 with Thaumcraft version 6.1.BETA26