search

RSC-Labs / backstage-highlights-plugin

Backstage Highlights Plugin is configurable and customizable plugin for viewing the most important information about your entity.
Mozilla Public License 2.0
5 stars 1 forks source link

Invalid tag and commit URL #3

Closed oleh-hutsalo-ks closed 3 months ago

oleh-hutsalo-ks commented 4 months ago

I found an issue with tag and commit URL concatenation

https://github.com/RSC-Labs/backstage-highlights-plugin/blob/9266654f2c886c1cfd977dd280d398b9e6ca6ef0/plugins/backstage-highlights-plugin-backend/src/lib/fetchTags.ts#L43-L45

Here is a quick fix

 tagUrl: `${repoInfo.data.html_url}/releases/tag/${singleData.name}`, 
 commitId: singleData.commit.sha, 
 commitUrl: `${repoInfo.data.html_url}/commits/${singleData.commit.sha}`,
radoslaw-sz commented 4 months ago

hi @oleh-hutsalo-ks thanks for raising this issue - looks like stupid bug :) I am wondering why it worked for me. I will fix it in some next days.

radoslaw-sz commented 4 months ago

hi @oleh-hutsalo-ks - possible fix landed in version 0.2.4. Please kindly check :)

radoslaw-sz commented 3 months ago

hi @oleh-hutsalo-ks - kindly reminder

oleh-hutsalo-ks commented 3 months ago

Thanks, everything works!