Closed nia-potato closed 2 months ago
hi @nia-potato - thanks for raising this issue. Indeed, the "clone" logic does not contain taking a host from app-config, but only focuses on annotations: https://github.com/RSC-Labs/backstage-highlights-plugin/blob/main/plugins/backstage-highlights-plugin/src/components/GitInfoCloneField.tsx#L36
I will try to fix it, but I cannot promise when. I am focusing on other project now, I need to finally switch to this one and fix all issues..
i can try to fix it, if you are busy, but would just like to ask you before i send in a PR.
i see the clone logic is hardcoded here, what annotation in mind do you want to source from the to fix this ?
should we use backstage.io/source-location:
annotation? or did you have something else in mind
hi @nia-potato - thanks for the proposal. Of course I am open for the PR.
I think we can use gitlab.com/instance
annotation which is related to component entity - https://github.com/RSC-Labs/backstage-highlights-plugin?tab=readme-ov-file#catalog-infoyaml.
The logic would be:
if gitlab.com/instance
is present then takes it, if not then go with hardcode gitlab.com
.
Hi thanks for the plugin,
I have configured the appconfig block
but when i hit the clone button, with the catalog-info.yaml defined with the project slug, it is still showing clone url of
gitlab.com/group/project.git
where it shouldve beengitlab.customdomain.com/group/project.git