search

RSCPlus / rscplus

RuneScape Classic client mod & preservation platform
https://rsc.plus
GNU General Public License v3.0
49 stars 35 forks source link

IP address in use message could use some tweaking #199

Open aldrichdev opened 9 months ago

aldrichdev commented 9 months ago

This always says only 1 character can be used at once, regardless of the MAX_PLAYERS_PER_IP setting.

Maybe change it to something more generic like "You may only use so many accounts at once" unless the current message is important for authenticity.

image

Hubcapp commented 9 months ago

Unfortunately, that message is hard-coded in the client and can't be changed.

It is definitely confusing to users, and so a custom response code (possibly of 26) is a definite addition for upcoming openrsc server type extensions. type 26 should allow the server to send the client a custom string to display. Type 26 when received by an unmodified 234 client will just show a generic error message, but not crash. Maybe we can also send a different client version to inform the server we understand more than an unmodified 234 client, but maybe that's not desired. We'll see.

Hubcapp commented 9 months ago

We could also just change the message for that response code in openrsc server config mode. Maybe there is a custom packet that is ignored by base 234 client, but rsc+ client with openrsc extensions can interpret it similarly to the "server configs" packet in the Custom Client protocol, and it could inform the client how many characters at once are allowed, which is,.... probably the best approach. :-)