search

RSCodingClub / STUCO-Backend

MIT License
3 stars 0 forks source link

Better organized setup file. #54

Closed itotallyrock closed 7 years ago

itotallyrock commented 7 years ago

The current setup file is 250 lines long with a third of those commented out old code. It has way too much functionality for one file. It's so improperly setup it won't even JS Beautify. It doesn't match any of the code and is simply a place to app.use any middleware then listen the server. The entire top half of the file is defining variables, half of that is requiring dependencies and the other half is defining globals, which in itself is bad practice.

itotallyrock commented 7 years ago

This is a major issue and is being dealt with in #53 and #47 which both seek to remedy this. The improved project structure will remove the need for many of the lines of code. And better use of configuration will completely remove the need for defining those nasty globals.