RSDKModding / RSDKv3-Decompilation

A Full Decompilation of Sonic CD (2011) & Retro Engine (v3)
Other
591 stars 120 forks source link

Can not build #228

Closed KeeveeKoomoo closed 11 months ago

KeeveeKoomoo commented 11 months ago

Expected Behavior

When I enter the command "cmake -Bbuild -DCMAKE_TOOLCHAIN_FILE=[vcpkg folder path here]/scripts/buildsystems/vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x64-windows-static -DCMAKE_PREFIX_PATH=[vcpkg folder path here]/installed/x64-windows-static" sonic cd will be built into the build folder

Actual Behavior

the cmd window returns an error "CMake error at cmakelists.txt:62 (include): include could not find requested file: platforms/msys.cmake

Steps to Reproduce

I followed the instructions step by step given on the github I got to the part where you input the above command, making sure to add the correct file paths in place of [vcpkg source here] etc etc Following output in screenshots

Screenshots

image

Log File

No response

Decompilation Version

I'm not sure, whatever the latest is at the time of this bug report. Sorry :(

Game Version

Sonic Origins

Game Revision

No response

Script Platform Type

Standard

Renderer Type

Hardware Renderer

Platform

Windows

Additional Comments

No response

KeeveeKoomoo commented 11 months ago

Also, something I tried to do to fix it was renaming the file named "windows.cmake" in the platforms folder to "msys.cmake". This yielded a different error, none of the libraries I installed with vcpkg could be found, no matter where I placed the folders found in the "installed/x64.../include"

KeeveeKoomoo commented 11 months ago

Thanks lol if I was able to do that myself but didn't, I'm sorry it's like 2 in the morning

KeeveeKoomoo commented 11 months ago

I figured out why it was looking for msys.cmake, for some reason msys was being deducted as the platform as shown by this screenshot in visual studio image

I changed the makefile to only support windows since that's all I need it for, however I get the above error where it cannot find any of the libraries

KeeveeKoomoo commented 11 months ago

How soon should I expect to hear anything back about this?

BooBerry commented 11 months ago

I haven't been able to compile this using cmake on Windows either for the RSDKv5 decomp (but can via Visual Studio) but it does work for the RSDKv3 decomp here for CD. As long as cmake is in the system PATH and you modify the cmake command specifying the full path for vcpkg and the triplet, it should work fine.

Compiling via Visual Studio 2022 (once setting up the dependencies manually) works fine too.

KeeveeKoomoo commented 11 months ago

Would you be able to either walk me through setting up visual studio to build the decomp or show me where I can find some instructions on how to do so? I'm very new to building decompilations like this.

KeeveeKoomoo commented 11 months ago

Yeah, I haven't been able to compile this using cmake on Windows either, but I can on Linux.

Compiling via Visual Studio 2022 (once setting up the dependencies manually) works fine too.

Linux gives the same errors image

BooBerry commented 11 months ago

There's a video somebody made that should help.

https://www.youtube.com/watch?v=CO7GpbWuzDI

KeeveeKoomoo commented 11 months ago

There's a video somebody made that should help.

https://www.youtube.com/watch?v=CO7GpbWuzDI

I've left a comment in that video already, I went there first

KeeveeKoomoo commented 11 months ago

I followed the video step by step and it still doesn't work, I even have the C++ desktop development thing installed in visual studio, something the author of the video forgot to mention in the video

KeeveeKoomoo commented 11 months ago

image

KeeveeKoomoo commented 11 months ago

I don't know what I'm doing wrong, unless there is something that hasn't been included because it's common knowledge among people who compile stuff frequently.

BooBerry commented 11 months ago

Just tried compiling with both cmake and VS in Windows 11, and both work fine as long as the dependencies are met (and you modify the cmake command to add the full path to vcpkg and the triplet used, otherwise if you copy and paste as-is it won't work.

KeeveeKoomoo commented 11 months ago

one sec, I'm gonna screen record a video of me trying to compile it whist following the instructions, if you don't end up seeing the video, it's because it decided to work when I was trying to show somebody else lol.

KeeveeKoomoo commented 11 months ago

Right so one thing I did notice was in the dependencies.txt, there are some instructions that were not mentioned in the video, I will try those before I show my screen record, as I don't really think my screen record will help too much as I am just following the instructions and it's very similar to the video that you sent to me

BooBerry commented 11 months ago

If you're going the vcpkg+cmake route, you don't need to follow the dependencies.txt instructions. But following them should allow it to compile in Visual Studio.

Though be sure you build the static solutions for libogg, libvorbis and libtheora in Visual Studio (and make sure they're set to Release x64 instead of Debug x64 when compiling each) before compiling RSDKv3.sln (as Release x64) in Visual Studio.

KeeveeKoomoo commented 11 months ago

image Any ideas what to do here? I made sure it's the release version

MegAmi24 commented 11 months ago

Closing this since there doesn't seem to be any interest in solving the original problem