Not working on Windows 7. Support?

60fpshacksrock commented 2 months ago

Before opening this issue, I ensure that...

[X] I have read the FAQ and confirmed my issue is not mentioned in it.
[X] I have checked both open and closed issues and confirmed this bug has not already been reported.
[X] I am not asking for tech support (e.g. game closing on startup, error when trying to build, etc).
[X] I am not asking for modding support or reporting a bug in a specific mod; this bug either occurs without mods enabled or is directly related to the mod loader.
[X] This bug is not related to any unofficial fork/port of the decompilation, and any issues with those should be kept in the appropriate repository.

Expected Behavior

Work

Actual Behavior

It will not work due to needing XInput 1.4 and XAudio 2.9

Steps to Reproduce

Try to run exe
Warns about required dll's, which are not available on Windows 7
Stops execution and exits

Screenshots

No response

Log File

No response

Decompilation Version

1.1.0 (https://github.com/RSDKModding/Sonic-Mania-Decompilation/releases/download/v1.1.0/mania-windows-x64.zip)

Game Version

1.04 / 1.05 (Mania Plus release)

Engine Revision

REV0U (RSDKv5U)

Platform

Windows

Additional Comments

No response

Mefiresu commented 2 months ago

The releases and github actions artifacts are built with the Windows 10 SDK, which dynamically links with these specific versions that are not present on Windows 7. There's no easy workaround for now, you would need to manually build with Windows 7 SDK (+ potentially fix compilation issues) for it to work on there.

For a more long term solution and future reference: XAudio 2.9 can be statically linked with support for Windows 7 (https://learn.microsoft.com/en-us/windows/win32/xaudio2/xaudio2-redistributable). I assume the same thing exists for XInput.

Sonic-The-Hedgehog-LNK1123 commented 2 months ago

The releases and github actions artifacts are built with the Windows 10 SDK, which dynamically links with these specific versions that are not present on Windows 7.

That statement is false, those library versions can be chosen independently of the Windows SDK version.

I have a Windows 7 compatible build, and it took 2 project-level changes:

Link XInput9_1_0.lib instead of XInput.lib
Use this XAudio 2.9 Nuget package and follow the instructions linked by Mefiresu's comment.

I didn't get any compilation errors after these changes.

Example where XInput.lib is specified in one of the project files: https://github.com/RSDKModding/RSDKv5-Decompilation/blob/1220d9140f693c8001789d13248d635b67adf262/RSDKv5/RSDKv5_dx9.vcxproj#L697

Note: that line occurs 3 more times in that file (once for each configuration and platform), same for the RSDKv5U project file.

Also, this only applies to the DirectX 9 build, the (custom) DirectX 11 build seems to actually use some DirectX 11.1 features not available on Windows 7, even with the platform update

Maybe reopen this issue?, as it was closed based on incorrect assumptions.

Mefiresu commented 2 months ago

That statement is false, those library versions can be chosen independently of the Windows SDK version.

I never said they couldn't be changed independently of the SDK version, I only said that the releases/actions builds use the W10 SDK, which means it defaults to linking with the versions that are provided by the SDK.

If you wanna be pedantic, my link states that it's a redistributable version made with support for older versions of Windows, and the Microsoft documentation for XAudio versions shows that the 2.7 version didn't ship with the OS, but with the DirectX SDK, and was the go-to version for Windows 7.

As for the XInput version you've linked with, they never actually backported the latest 1.4 version to Windows 7 and just kept the 9.1.0 version as a backwards compatible version.

Now for this project, the Windows build steps were made with Windows 10 in mind (safe to assume considering it's been there since 2015 and the end of support for Windows 7 was 4 years ago), so nobody bothered making sure it was backwards compatible with Windows 7 by manually linking with specific versions of each library, and we went with whatever the SDK/host OS shipped with (we're not even explicitly linking with XAudio anywhere and XInput is passed without a version).

I agree that this issue should be kept opened (changing it now). That said, if you want to set up a way to provide support for Windows 7 for this project using CMake (the now preferred build system for this project), feel free to send a PR.

Sonic-The-Hedgehog-LNK1123 commented 2 months ago

I never said they couldn't be changed independently of the SDK version, I only said that the releases/actions builds use the W10 SDK, which means it defaults to linking with the versions that are provided by the SDK.

Your original statement doesn't make that obvious to other people since the words "by default" are missing from your original statement. (at least the XInput9_1_0.lib library is provided by the SDK)

There's no easy workaround for now, you would need to manually build with Windows 7 SDK (+ potentially fix compilation issues) for it to work on there.

That statement is false, since the Windows 10 SDK can still target Windows 7, (and @MegAmi24 might have initially closed this issue based on your comment, as changing SDKs not being an option here)

XInput is passed without a version

That version-less library pretty much means the latest version available as of this Windows SDK release

I've never used CMake before, but I'm pretty sure that changing the mentioned line to XInput9_1_0 will cause it to link to XInput9_1_0.lib/dll.

For the XAudio Nuget package you apparently need to use VS_PACKAGE_REFERENCES somewhere in that file to add the Nuget package.

I hope my comments on CMake are helpful. I don't have my build system ready right now due to some real-life issues, but I'll test this when I get my build system ready and I have the time for it.

RSDKModding / RSDKv5-Decompilation