RSDKModding / RetroED

RetroED v2.0
GNU General Public License v3.0
27 stars 5 forks source link

[Animation Editor - v1/2] Editing files is a bit unstable, invalid empty sheet slots (v2) and unable to save new file (v1/2). #130

Closed LittlePlanetCD closed 2 months ago

LittlePlanetCD commented 3 months ago

Before opening this issue, I ensure that...

Editor Tool

Animation Editor

RSDK Version

v1, v2

Expected Behavior

Smooth editing experience, able to add new sheets, remove them, as well as create new animaton files from scratch.

Actual Behavior

invalid sheets exist, cannot create new v2 file easily, crashes on both.

Steps to Reproduce

To find the invalid sheet issue for v2:

  1. Open Sonic Nexus' Sonic .ani file
  2. Open sheets section
  3. Click below the last sheet text, it should select a blank one you cannot remove, nor replace. (removing or replacing cause a crash.)

To find the crash when creating a new v1 or v2 file:

  1. Open animation editor
  2. add new animation, save as v1 or v2 file
  3. crash.

Screenshots

image

Was another editor used on the file(s)?

No.

Platform

Windows 10 22H2

Additional Comments

I'm assuming the save crash is probably because the editor assumes you're making a different type of file at first rather than what you're saving to, causing it to get confused? it seems to be a bit better if you just edit from an existing RSDKv1/2 file and save.

the invalid sheet issue is interesting, as i had tried to do further research on it, and i found out that if you remove existing sheets with the old RSDK Animation Editor tool and open them here, there will be 4 empty, invalid slots.

Edit: Turns out Nexus players support 4 sheets at once, but Sonic's original file has 3. RetroED might need some kind of "default path" for empty sheet slots. in other versions that could potentially have these empty slots (v3/4/5), maybe have them be cleared there?