RSDKModding / Sonic-Mania-Decompilation

A complete decompilation of Sonic Mania (2017)
Other
632 stars 116 forks source link

Make cutscene code more accurate #224

Closed Mefiresu closed 1 year ago

Mefiresu commented 1 year ago

In the original code, cutscene objects do not set the skipCallback field unless when using SKIPTYPE_CALLBACK. Make CutsceneSeq_SetSkipType only set the skip type (for non-callback skips), and introduce a new CutsceneSeq_SetSkipTypeCallback which sets the skip type as SKIPTYPE_CALLBACK and only takes the callback function as parameter. Enforce usage of these functions everywhere in the code. Also add them in the public function list so they can be used in mods.

Add {CPZ1Intro/SSZ1Intro}_SetupCutscene functions that are in the original (Steam) but weren't in the decomp.

Also fixes #214, along with multiple inaccuracies: