search

RSDKModding / Sonic-Mania-Decompilation

A complete decompilation of Sonic Mania (2017)
Other
632 stars 116 forks source link

Screen Filter setting does not persist #266

Closed camthehaxman closed 9 months ago

camthehaxman commented 9 months ago

The "Screen Filter" option in Sonic Mania's video options does not persist and will be reverted back to "NONE" if the game is closed and restarted. I'm not sure if this is an issue with Sonic-Mania-Decompilation or RSDKv5-Decompilation (it seems like more of an engine level thing to me), so please excuse me if I've posted this in the wrong place.

OS: Void Linux x86-64 Data.rsdk: MD5: 919e7ff8ec8ed3694c77ed71cca9984f, comes from the latest Steam version at the time of writing.

Steps to reproduce

  1. Clone the Sonic Mania decompilation: git clone --recursive https://github.com/Rubberduckycooly/Sonic-Mania-Decompilation
  2. Build the game: cd Sonic-Mania-Decompilation && mkdir build && cd build && cmake .. && make -j4
  3. Copy the Data.rsdk file from your Steam installation: cp "$HOME/.steam/steam/steamapps/common/Sonic Mania/Data.rsdk" .
  4. Run the game: ./dependencies/RSDKv5/RSDKv5U
  5. On the main menu, go into OPTIONS, then VIDEO.
  6. Change FULL SCREEN to ON, so that we can see the effects. Press the W key on your keyboard to apply. Answer YES to keep settings.
  7. Change SCREEN FILTER to CLEAN. Press the W key on your keyboard to apply. The image will appear sharper.
  8. Close the game window with Alt+F4 or whatever other shortcut your desktop uses.
  9. Re-open the game.
  10. The SCREEN FILTER will have reverted back to NONE, and the image will look a little blurry.

Expected Behavior

The SCREEN FILTER option should persist with CLEAN after pressing W and restarting the game.

Actual Behavior

The SCREEN FILTER option always reverts back to NONE upon restarting the game.

Mefiresu commented 9 months ago

After checking the behavior on the Steam release, it appears that the game only saves the selected screen filter when exiting the video settings menu (hitting W to apply doesn't do anything either). The decomp is accurate in that regard.

Mefiresu commented 9 months ago

Turns out the shader settings wasn't persisting at all even after exiting the video menu, found a couple inaccuracies thanks to this issue. Thanks!