RSDKModding / Sonic-Mania-Decompilation

A complete decompilation of Sonic Mania (2017)
Other
632 stars 116 forks source link

HCZ bubbles are very very broken #96

Closed Awuwunya closed 2 years ago

Awuwunya commented 2 years ago

unknown 1

These bubbles give a lot of problems in the decomp. If both the player and sidekick are inside of the bubble, the sidekick can affect the main player's bubble (including allowing it to clip through the ground below!) and not letting them go high enough. I have seen the sidekick's bubble get destroyed, for them to teleport to main player's bubble as well.

Additionally, the sidekick is always able to generate a bubble. This is not how Mania 1.06 works though. In fact, the sidekick is only able to sometimes generate a bubble, and I think it works if there is a bubble object that already exists, but not always. In the decomp, the sidekick always generates a bubble.

Rubberduckycooly commented 2 years ago

fixed sidekick being able to generate bubbles in 3838cdcd014d2e00ffb9a804735b7c92ac6aef74, unable to replicate the sidekick affecting the player's bubble or anything like that

stxticOVFL commented 2 years ago

Please re-open if the second part of the issue persists.

Awuwunya commented 2 years ago

I am unable to check this because when I compile, I get the following error: LNK2001 unresolved external symbol PBL_Player_StageLoad SonicMania (v5U)

breakthetargets commented 2 years ago

@NatsumiFox what are you using to build again, because visual studio over here is still working just fine.

Awuwunya commented 2 years ago

Visual Studio.