RSDuck / vba-next-switch

Libretro VBA-Next port for Switch. **Don't use this, see readme!**
GNU General Public License v2.0
110 stars 11 forks source link

Menu isn't fullscreen when docked #21

Open vitormmatos opened 6 years ago

vitormmatos commented 6 years ago

When docked the menu becomes little, close to a quarter of the screen, on top left. Still the A, B and X labels still appear on right bottom of TV, but with no text, where there is just a black background.

dene- commented 6 years ago

We already know and discussing this issue. This issue can be closed now.

RSDuck commented 6 years ago

we better keep it open, so everybody knows how the status is on this problem

fennectech commented 6 years ago

Thanks. Was about to report this xD I think the text is there but it is hiding in the black I can test for you. It happens irrelevant of resolution. Same on all of them.

dene- commented 6 years ago

Actually all UI elements positions are hardcoded for 720p screen, they only need to be updated to 1080p.

int uiMargins[SOMEMAXSIZE][SOMEMAXSIZE];

typedef enum {
  HANDLED,
  DOCKED
} ScreenMode;

typedef enum {
  marginOne,
  marginTwo,
  paddingOne,
  ...
}

void init() /* or on framebuffer size change, if possible */ {
  uiMargins[HANDLED][marginOne] = someValue;
uiMargins[DOCKED][marginOne] = someOtherValue;
}

Probably not the best option but that it might be easier to maintain, to some extent.

fennectech commented 6 years ago

Well. I only last week upgraded to a 1080 tv. Plus the internal panel is 720p so a 1080p signal could cause issues. If we run at 720p even on 1080p displays that should solve our problem

deltaryz commented 6 years ago

There's no reason it can't change the resolution based on the display. That's what the rest of the system does - runs at 720p in handheld, and 1080p while docked. It's not locked to one hardcoded resolution, it can change.

fennectech commented 6 years ago

So we would be adding profiles for 480p and 720p that are selected based on the display were using?

RSDuck commented 6 years ago

no, the "profile" thing is something completely internal. You really don't have to care about it.

dene- commented 6 years ago

If someone has a TV to test DM me on Discord to test a dev build! (My Discord is on GBATemp signature)

fennectech commented 6 years ago

What’s your discord username.