Closed JohnGarbutt closed 4 years ago
Merging #132 into master will increase coverage by
0.15%
. The diff coverage is76.47%
.
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 50.44% 50.59% +0.15%
==========================================
Files 31 31
Lines 1911 1925 +14
==========================================
+ Hits 964 974 +10
- Misses 875 879 +4
Partials 72 72
Impacted Files | Coverage Δ | |
---|---|---|
internal/pkg/config/filesystem.go | 0.00% <0.00%> (ø) |
|
internal/pkg/filesystem_impl/mount.go | 42.22% <66.66%> (+0.55%) |
:arrow_up: |
internal/pkg/filesystem_impl/ansible.go | 45.29% <84.61%> (+2.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ebf84b8...a772b49. Read the comment docs.
Added the config: DAC_MGS_HOST
By default it is localhost, which is existing behaviour where MGS always lives on the primary brick host.
We found operational issues of when to clean out the MGS after creating lots of filesystems. Eventually the MGS will fill up. As a work around, we allow operators to specify a custom location (host and device) for the MGS. This means you could easily rotate a single MGS (via change of config followed by reboot of dacd) that ensures the correct thing happens.