search

RSE-Sheffield / RSEAdmin

A Resource Allocation and Finance tool for RSE Groups
https://rseadmin.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Change default filter for RSE allocation view so rejected projs not shown; linting #138

Closed willfurnass closed 2 years ago

willfurnass commented 4 years ago

I think this makes sense - @mondus?

NB only logic change is around line 111 - all other changes are linting.

codecov-io commented 4 years ago

Codecov Report

Merging #138 into master will decrease coverage by 0.16%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   78.83%   78.66%   -0.17%     
==========================================
  Files          41       41              
  Lines        3647     3647              
==========================================
- Hits         2875     2869       -6     
- Misses        772      778       +6
Impacted Files Coverage Δ
rse/forms.py 54.91% <75.00%> (ø)
timetracking/views.py 48.01% <0.00%> (-2.78%) :arrow_down:
rse/models.py 84.49% <0.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28f9d47...feb8445. Read the comment docs.