search

RSE-Sheffield / RSEAdmin

A Resource Allocation and Finance tool for RSE Groups
https://rseadmin.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Bump django version; allow 1% drop in coverage per PR #149

Closed willfurnass closed 3 years ago

willfurnass commented 3 years ago

See https://www.djangoproject.com/weblog/2020/sep/01/security-releases/

codecov-commenter commented 3 years ago

Codecov Report

Merging #149 into master will decrease coverage by 0.24%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   78.83%   78.58%   -0.25%     
==========================================
  Files          41       41              
  Lines        3647     3647              
==========================================
- Hits         2875     2866       -9     
- Misses        772      781       +9
Impacted Files Coverage Δ
rse/models.py 82.79% <0.00%> (-1.54%) :arrow_down:
rse/views/salary.py 61.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e6165e...a9206fb. Read the comment docs.

willfurnass commented 3 years ago

@mondus Do you care about this slight drop in coverage? A codecov check is failing.

willfurnass commented 3 years ago

I've added a codecov.yml file which should hopefully allow a 1% drop in coverage for a PR.