search

RSE-Sheffield / git-github-zero-to-hero

Training materials for zero to hero training in version control through git, github and gitkraken
https://srse-git-github-zero2hero.netlify.app/
17 stars 10 forks source link

Ns rse/75 remove git install #76

Closed ns-rse closed 1 year ago

ns-rse commented 1 year ago

Closes #75

As discussed because GitKraken does not require any Git tools participants only need to install GitKraken and they should be good to go.

However if someone could confirm this (particularly under Windows) that would be great.

Under Arch Linux I've checked the GitKraken Terminal with which git and its picking up the system one (/usr/bin/bit) which raises a slight cause for concern.

davidwilby commented 1 year ago

Under Arch Linux I've checked the GitKraken Terminal with which git and its picking up the system one (/usr/bin/bit) which raises a slight cause for concern.

Same under Ubuntu linux.

EdwinB12 commented 1 year ago

Can confirm on Windows, GitKraken comes with git.

davidwilby commented 1 year ago

Can confirm on Windows, GitKraken comes with git.

Out of interest, how have you confirmed this? Same as above?

Is this kind of moot if on Windows GitKraken comes with git? Do all linux distros have git installed? Ubuntu does, I think.

According to this thread, MacOS doesn't though https://developer.apple.com/forums/thread/672087

EdwinB12 commented 1 year ago

The laptop I tested it on didn't have git installed. After installing gitkraken, I could use all of gitkraken git capabilities like cloning etc.

ns-rse commented 1 year ago

@davidwilby I'd hazard a guess that almost all Linux distros come with Git (but if you're using something like Arch or Gentoo which might not then you would likely have installed it anyway or know how to).

@EdwinB12 Thanks for the confirmation on Windows (and OSX @davidwilby ). I think as GitKraken bundles it (and states as such) we can safely move instructions for installing Git to the Optional as this PR has done.

That just leaves the question of whether we want to include the existing instructions there or as @bobturneruk suggests removing them completely and linking out to them. I don't mind them staying in myself but happy to change to links to installation instructions if others think so. @annakrystalli do you have any preference?

netlify[bot] commented 1 year ago

Deploy Preview for peppy-otter-7a55ad ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/peppy-otter-7a55ad/deploys/63db9cd85db0cb3ab6d4149a
Deploy Preview https://deploy-preview-76--peppy-otter-7a55ad.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.