Closed Robadob closed 7 months ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/RSE-Sheffield/pando-python/compare/md-outputs..md-outputs-PR-28
The following changes were observed in the rendered markdown documents:
config.yaml | 1 +
fig/mydevelopment.png (new) | Bin 0 -> 113753 bytes
index.md | 3 +++
md5sum.txt | 5 +++--
registration.md (new) | 18 ++++++++++++++++++
5 files changed, 25 insertions(+), 2 deletions(-)
:stopwatch: Updated at 2024-04-08 11:02:50 +0000
I'm fine with making it Sheffield specific. When I submit to carpentry incubator it will be a fork with Sheffield stripped out. There are/will-be other Sheffield references within the course.
On Wed, 3 Apr 2024, 16:17 Neil Shephard, @.***> wrote:
@.**** commented on this pull request.
Nothing significant to add, although I'd be somewhat wary of making the Workbench too specific to Sheffield.
This is the sort of content/material I think would sit nicely as a separate page linked from RSE Sheffield - Training https://rse.shef.ac.uk/training/.
In learners/registration.md https://github.com/RSE-Sheffield/pando-python/pull/28#discussion_r1549951247 :
@@ -0,0 +1,16 @@ +--- +title: 'Registration Information' +--- + +*If you're external to the University of Sheffield and are interested in us delivering the course at your institution, delivering or taking it yourself, [reach @.**?subject=[pando-external]) for more information or advice. + +This course currently runs for PhD students and staff at the University of Sheffield roughly once a month on Thursdays. + +If you're interested in registering to take the course, and have checked that you meet the prerequisites (this course isn't very suitable for Python beginners), search for "profiling" on MyDevelopment and sign up for the next run that fits your schedule.
I'd remove the very just to make it quite clear that beginners shouldn't be taking this course. ⬇️ Suggested change
-If you're interested in registering to take the course, and have checked that you meet the prerequisites (this course isn't very suitable for Python beginners), search for "profiling" on MyDevelopment and sign up for the next run that fits your schedule. +If you're interested in registering to take the course, and have checked that you meet the prerequisites (this course isn't suitable for Python beginners), search for "profiling" on MyDevelopment and sign up for the next run that fits your schedule.
— Reply to this email directly, view it on GitHub https://github.com/RSE-Sheffield/pando-python/pull/28#pullrequestreview-1977153406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVGCWWD7PAJPVFNQJYOM3Y3QMPFAVCNFSM6AAAAABFNLIBZGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZXGE2TGNBQGY . You are receiving this because you authored the thread.Message ID: @.***>
I'll adjust this with direct link to MyDevelopment and add a comment saying you may need to log into mydevelopment before clicking this link 🙄, before I merge. But otherwise ready to go.
Interested in whether you think there's anything more I should add @ns-rse.
I also still need to get the feedback form off you to add to the end of the course.
My idea with the registration page is to add a link to the main RSE website nav that links to pando.