Closed muneerahp closed 3 years ago
Thanks for reporting this.
As you can see from wayback machine https://web.archive.org/web/20201006082650/https://www.sheffield.ac.uk/autumn-term-2020/covid-19-statistics the *
for a footnote has been added. sigh
I suggest extending validate()
so that it specifically checks and removes a single final star in the cell string. It's good to be conservative, because we'd rather fail than accept something that was wrong.
closed by #15
Fairly sure this is a bug, but just in case, since this is the first time I'm running this:
python code/ingest.py
as in the readme. No issues here.Ran, and got:
Checked the debugger, and it looks like the
"rows"
intransform
has:['Monday 28 September', '1*', '19*']
as part of the list.Checked the website, and the table this data looks like it was pulled from also has said stars in the values. Happy to add a bugfix (some kind of type check/conversion before applying any operations?) if this is confirmed to be an actual bug for everybody, and not some weird first run issue for me.