search

RSE-Sheffield / sheffield-covid-19

Scrape COVID-19 data from the University website
1 stars 8 forks source link

Add type hints #19

Open willfurnass opened 3 years ago

willfurnass commented 3 years ago

Just for fun. Won't be offended if this isn't merged.

NB type hints allowed for the identification of interesting potential issues e.g. Element.text can return None.

drj11 commented 3 years ago

Did you run pylint or similar as hinted in the contributing? https://github.com/RSE-Sheffield/sheffield-covid-19/blob/main/contributing.md#static-analysis

willfurnass commented 3 years ago

Rebased on main to include commits from PR #18.

@drj11 Yes, I ran pylint: warnings from pylint are unrelated to this PR.

drj11 commented 3 years ago

Not compatible with the latest typelint checks (that I just merged)

willfurnass commented 3 years ago

Rebased the PR on main so we can see the effect of the new type-hint-hating check (PR #20) when new Travis jobs run :)

drj11 commented 3 years ago

In a way it's quite funny:

exited with 7

willfurnass commented 3 years ago

The use of the return code to indicate the number of type annotations is inspired!

I think this might be check mate so feel free to close.