Closed muneerahp closed 3 years ago
Since this works and is an improvement, I'm happy to merge this as-is.
There are minor niggles, but it's up to you if you want to fix those here or in a new PR. Let me know.
pytest
way to do fixtures, that's for both of us to find out);black
doesn't change the code, might be a good addition to CI).Fixed the ones that seem good to fix before a merge (eval to json/black formatting), can handle the rest in a new PR.
JSON seems cleaner, so changed. I assume the issues with eval in general are security related, rather than "this will cause something different to happen across different systems" (it doesn't seem it will, any more so than code not run by eval at least)?
The empty __init__.py
files are a bit annoying. But I don't know enough to remove them. More studying of https://github.com/pypa/sampleproject is possibly required.
thanks!
thoughts welcome.