search

RSGInc / bca4abm

Benefit Cost Analysis for Travel Demand Models
http://rsginc.github.io/bca4abm/
Other
7 stars 5 forks source link

Python 3 #103

Closed blakerosenthal closed 5 years ago

blakerosenthal commented 5 years ago

Support for Python 3, with Python 2.7 backwards compatibility provided by the future package.

This requires using the latest ActivitySim, and BCA needs some small module changes to accommodate. Injectables now use activitysim.core.inject instead of orca. Several config files require some minor syntax adjustments. The chunk module in asim has been expanded since v0.7 and the logging method chunk.log_df_size has been replaced by chunk.log_df.

https://github.com/RSGInc/bca4abm/issues/97, like for asim and popsim, there's also the question of if/when we should phase out Python2 support entirely. Any strong opinions on this? I think we should consider dropping Python 2 compatibility entirely within the next couple months. Most of our dependencies are going to start breaking any time now, and it we could facilitate a smooth-ish transition to Python 3 for asim/popsim/bca users.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 95.271% when pulling 1578cbc3366fa0ddbb23bae198829e8b0216970f on py3 into 20f56cf1a0e0f6a4017132762039af6296798496 on master.