search

RSNA / ACR-RSNA-CDEs

JSON schema and other materials related to the joint ACR-RSNA project to create common data elements.
https://radelement.org/
14 stars 5 forks source link

Description Updates #56

Closed shadowdoc closed 6 days ago

shadowdoc commented 2 months ago

@radngandhi - A few comments on this.

1 - The @ need to be our github usernames. For me it's @shadowdoc, tarik is @talkasab. The folks you tagged are probably fairly confused! 2 - For set_version I would recommend adding that this is an auto-increment field that goes up by one each time a set (or element) is sent to radelement 3 - The URL element should stay as format URI. URI is a more generic specification than a URL and is JSONSchema compliant (https://json-schema.org/understanding-json-schema/reference/string)

If you make these changes, commit again and then push your changes they will be added to this pull request.

TY!

shadowdoc commented 2 months ago

Also, congrats on being able to successfully push to the repo and make these changes! Respect!