RSPSApp / elvarg-rsps

17 stars 39 forks source link

210 runelite defs #247

Closed MatthewBishop closed 1 year ago

MatthewBishop commented 1 year ago

very much WIP as I go through and cleanup stuff.

basically right now this is loading current defs and then osrsbox on top for any data within those files so that it works ingame.

right now I am inferring that they are attackable if the osrsbox defs contain an hp >0 so that it works properly ingame for npcs, but when i update the elvarg specific/non osrsbox data it will be based off of whether npc has attack as the tooltip.

MatthewBishop commented 1 year ago

Some issues:

The Region based npc processing has issues with npcs not getting processed which prevents damage application. There are NPCs located at y 3520 which stop moving when they hit that coordinate.

This is specifically located to the isActive method within region and these npcs behave normally when the following line is commented out:

https://github.com/RSPSApp/elvarg-rsps/blob/210-runelite/ElvargServer/src/main/java/com/elvarg/game/World.java#L169

Additionally, this is now only using the animations from the original Elvarg file. These ids will get replaced/updated in either a future PR or later on this one.

MatthewBishop commented 1 year ago

New format for the Npc animation definitions. An example is here: https://github.com/RSPSApp/elvarg-rsps/blob/ca3b54d83bc5a036855e4b4a9e190cc666769108/ElvargServer/data/definitions/npc_anims.json#L24-L42