search

RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7.36k stars 1.04k forks source link

Item comments tag support #3656

Open Phantop opened 1 year ago

Phantop commented 1 year ago

Is your feature request related to a problem? Please describe. Some RSS readers, such as Miniflux, support a comments tag for feed entries. Entries with it will have a comments option that will go to the provided URL. A number of feeds are generated with this, but RSS-Bridge does not allow creating feeds with it. This limits bridges slightly and results in FeedExpander removing data from some source feeds. I've wanted to create some bridges that have this tag, and being able to both pull from existing RSS feeds and add to bridge entries I create is desirable.

Describe the solution you'd like Implementing the tag much like other bridge tags would be sufficient (e.g., the same as how $item['title'] functions.

Describe alternatives you've considered The only real alternative would be embedding the link in content, but this would ideally allow for use of an existing reader feature.

mruac commented 1 year ago

Huh, TIL. You are probably referring to the RSS <comment> element?

RSS-Bridge currently supports the following feed formats: Media RSS, Atom, JSON Feed and sfeed.

Since this is only specific to RSS, I think that providing support for only one feed format may not be within this project's goals, but maybe an extensible $item['item_element'] might be within scope, to allow extended FormatAbstract classes to discard elements that's not in their specs.

Phantop commented 1 year ago

Yeah I meant the <comment> element. An example of this problem at work can be seen with the Ars Technica bridge I recently PR'd, where that element is lost (as well as entry categories, though that's purely a FeedExpander issue).

dvikan commented 1 year ago

do you mean the <comments> element?

dvikan commented 1 year ago

@Phantop

Phantop commented 1 year ago

Yes, I meant the <comments> element as can be seen in this feed, my apologies.

Phantop commented 2 months ago

For what it's worth, I tried it out and it only requires a couple changes to add in comment support. Most of the code already exists for standard URI handling. I made a patch that I've been using on my own RSS-Bridge instance, and it seems to work fine.