search

RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7k stars 1.02k forks source link

Magikh42 steam app news use app name #3977

Open Magikh42 opened 4 months ago

Magikh42 commented 4 months ago

Bridge: Steam App News

Hello, I added a checkbox to allow using the app name instead of author name, I think it's more practical for filtering by game in the user's preffered reader

I might have swapped commit messages and description but I don't know how to change that, sorry If someone can set the messages to what I put in the description it would be nice, thank you

github-actions[bot] commented 4 months ago

Pull request artifacts

Bridge Context Status
SteamAppNews 1 untitled (current) ✔️
SteamAppNews 1 untitled (pr) ⚠️ (shutdown) 8192: Creation of dynamic property SteamAppNewsBridge::$app_name is deprecated in bridges/SteamAppNewsBridge.php line 59

last change: Tuesday 2024-03-19 10:50:28

dvikan commented 4 months ago

this will break existing feed urls because the tags parameter is gone.

Magikh42 commented 4 months ago

this will break existing feed urls because the tags parameter is gone.

Can you explain how it would break anything I don't understand The use_app_name is optional so previous feeds would still works using author name but new feeds could be generated using app name in place of author name

dvikan commented 4 months ago

rss-bridge disallows url parameters who are not defined in the bridge.

(i consider this a bug but havent found time to fix it yet.)

so when tags is gone, it will fail on all existing feed urls.

dvikan commented 3 months ago

@otakuf pls help

otakuf commented 1 month ago

@otakuf pls help

what help, sry i don`t get it. Magikh42 want to add some functionality.

dvikan commented 2 weeks ago

@Magikh42

there are feeds out there using this bridge. they might be using the tags parameter in those urls.

if tags parameter is removed, these feeds will break. do you understand?