search

RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7.37k stars 1.04k forks source link

Mrss feed format is wrong for most media based feeds #3979

Open KAGEYAM4 opened 9 months ago

KAGEYAM4 commented 9 months ago

Describe the bug I was using variety which requires Mrss feed, the only feed that worked was flikr. Most other feeds don't work. example - Pinterest

After inspecting flikr feed by searching with media there were many results. But only one media text was found in pinterest and other image based rss feeds.

To Reproduce Steps to reproduce the behavior:

  1. Generate Pinterest Mrss feed
  2. Load in https://github.com/varietywalls/variety using thes Add > MRss feed
  3. See error

image

Expected behavior Mrss to be correctly read by variety.

Desktop (please complete the following information):

dvikan commented 9 months ago

im not sure but im guessing they are looking for <media:content> element, which is absent from the pinterest feed.

in rssbridge, this particular element is deduced from bridge feeditem enclosures, of which pinterest has none.

dvikan commented 9 months ago

see https://github.com/RSS-Bridge/rss-bridge/pull/3980 whether it fixes the problem

KAGEYAM4 commented 9 months ago

see #3980 whether it fixes the problem

Do you want me to test? Do i use this https://github.com/RSS-Bridge/rss-bridge?tab=readme-ov-file#install-with-docker-compose for getting local installation and test it if it generates the correct feed ?

Also is the same issue with other feeds that don't generate <media:content> for example - danbooru, gelbooru etc. I did a search for image and most feeds have missing <media:content>

dvikan commented 9 months ago

https://rss-bridge.org/bridge01/?action=display&bridge=PinterestBridge&context=By+username+and+board&u=VIGOIndustries&b=bathroom-remodels&format=Mrss now emits the media:content element.

yes you can also install a copy of rssbridge on your local machine. either with docker or without docker. see readme. also an option to install on VPS of course.

other bridges will have same problem indeed. because they lack enclosures.

KAGEYAM4 commented 9 months ago

https://rss-bridge.org/bridge01/?action=display&bridge=PinterestBridge&context=By+username+and+board&u=VIGOIndustries&b=bathroom-remodels&format=Mrss now emits the media:content element.

Url of image resoure is missing inside <media:content> -> pinterest -> <media:content url="https://www.pinterest.com/pin/37576978135546631/" type="application/octet-stream"/> flikr -> <media:content url="https://live.staticflickr.com/65535/53526711005_7b1f81042e_z.jpg" type="image/jpeg"/>

other bridges will have same problem indeed. because they lack enclosures.

Ok, can they be fixed in future when you have time to look at them. Thank you.

dvikan commented 9 months ago

yes the pinterest media:content is pointing to a proper image. didnt find that data.

pls indicate which other bridges you want this for

KAGEYAM4 commented 9 months ago

yes the pinterest media:content is pointing to a proper image. didnt find that data.

To verify that i am not wrong, and you don't end up doing same work again. The flikr <media:content> has url of image which inside that ends in jpg but for pinterest there is no jpg in the url that is inside <media:content>

pls indicate which other bridges you want this for