search

RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7.23k stars 1.03k forks source link

[GenshinImpactBridge] Fix bridge to use new API #4011

Closed miicat closed 6 months ago

miicat commented 6 months ago

The bridge used old API to load the news and didn't get the latest ones anymore.

I updated it to use new API (which doesn't seem to have way to filter between categories, so I removed that option too)

github-actions[bot] commented 6 months ago

Pull request artifacts

Bridge Context Status
GenshinImpact 1 untitled (current) ✔️
GenshinImpact 1 untitled (pr) ⚠️ DEBUG lib/FeedItem.php(218): Enclosures must be an array!

last change: Thursday 2024-03-14 09:54:56

dvikan commented 6 months ago

have you considered that removing parameter category breaks existing feeds?

miicat commented 6 months ago

Yeah, I noticed that too when testing. It's easy to fix the existing feed by updating the url tho 🤔

But if you want, I can add it back

dvikan commented 6 months ago

im only thinking it would be nice for other users if it suddenly automatically works.

also see linter errors

dvikan commented 6 months ago

pls fix:

2024-03-14 09:55:07] rssbridge.DEBUG lib/FeedItem.php(218): Enclosures must be an array!
miicat commented 6 months ago

@dvikan Did you fix those? Or should I make new MR as you already merged this?

dvikan commented 6 months ago

did not.

merge anyways