RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
6.99k stars 1.02k forks source link

AO3Bridge: move tags to categories and remove duplicate fic summary #4031

Closed Phantop closed 3 months ago

github-actions[bot] commented 3 months ago

Pull request artifacts

Bridge Context Status
AO3 1 List (current) ✔️
AO3 1 List (pr) ✔️
AO3 2 Bookmarks (current) ✔️
AO3 2 Bookmarks (pr) ✔️
AO3 3 Work (current) ✔️
AO3 3 Work (pr) ✔️

last change: Wednesday 2024-03-27 20:49:41

dvikan commented 3 months ago

the change introduced this error:

[2024-03-31 00:50:53] rssbridge.ERROR Exception in RssBridge::main() {
    "type": "Error",
    "code": 0,
    "message": "Call to a member function find() on null",
    "file": "bridges/AO3Bridge.php",
    "line": 81,
    "url": "https://rss-bridge.org/bridge01/?action=display&bridge=AO3Bridge&context=List&url=https%3A%2F%2Farchiveofourown.org%2Fusers%2FDraconicHex%2Fpseuds%2FDraconicHex&format=Atom",
    "trace": [
        "index.php(72): RssBridge->main()",
        "lib/RssBridge.php(103): DisplayAction->execute()",
        "actions/DisplayAction.php(68): DisplayAction->createResponse()",
        "actions/DisplayAction.php(118): AO3Bridge->collectData()",
        "bridges/AO3Bridge.php(57): AO3Bridge->collectList()",
        "bridges/AO3Bridge.php(81)"
    ]
}
Phantop commented 3 months ago

the change introduced this error:

[2024-03-31 00:50:53] rssbridge.ERROR Exception in RssBridge::main() {
    "type": "Error",
    "code": 0,
    "message": "Call to a member function find() on null",
    "file": "bridges/AO3Bridge.php",
    "line": 81,
    "url": "https://rss-bridge.org/bridge01/?action=display&bridge=AO3Bridge&context=List&url=https%3A%2F%2Farchiveofourown.org%2Fusers%2FDraconicHex%2Fpseuds%2FDraconicHex&format=Atom",
    "trace": [
        "index.php(72): RssBridge->main()",
        "lib/RssBridge.php(103): DisplayAction->execute()",
        "actions/DisplayAction.php(68): DisplayAction->createResponse()",
        "actions/DisplayAction.php(118): AO3Bridge->collectData()",
        "bridges/AO3Bridge.php(57): AO3Bridge->collectList()",
        "bridges/AO3Bridge.php(81)"
    ]
}

Ah my mistake! I hadn't thought to test against user pages. The issue can be fixed by removing the > in the selector on line 80, I'm fairly certain. I can open a new PR with the change, if you'd like.

dvikan commented 3 months ago

yes pls make pr