search

RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
6.99k stars 1.02k forks source link

[prtester.py] fix url parameter encoding #4052

Closed User123698745 closed 2 months ago

User123698745 commented 2 months ago

This PR will fix the Invalid parameters value error message in the pull request artifacts / pr preview, which occurred in https://github.com/RSS-Bridge/rss-bridge/pull/4025#issuecomment-2028501667 .

Instead of building the url by manually concatenating the parameters, the prtester.py script will now use urllib.parse.urlencode to ensure all url parameters get encoded correctly.

It will (at least) fix the pr preview of: bridges/AnisearchBridge.php bridges/BakaUpdatesMangaReleasesBridge.php bridges/DesoutterBridge.php bridges/IndiegogoBridge.php

(Note: The pr previews of this PR will still not work, because prtester.py of the target master branch will get used)

github-actions[bot] commented 2 months ago

Pull request artifacts

Bridge Context Status
Anisearch 1 untitled (current) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): synchro, sort, order, view
Anisearch 1 untitled (pr) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): synchro, sort, order, view
BakaUpdatesMangaReleases 1 By series (current) ✔️
BakaUpdatesMangaReleases 1 By series (pr) ✔️
BakaUpdatesMangaReleases 2 By list (current) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): list
BakaUpdatesMangaReleases 2 By list (pr) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): list
Desoutter 1 News & Events (current) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): Events
Desoutter 1 News & Events (pr) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): Events
Desoutter 2 Industry 4.0 News (current) ✔️
Desoutter 2 Industry 4.0 News (pr) ✔️
Indiegogo 1 All Categories (current) ⚠️ DEBUG lib/FeedItem.php(217): Enclosures must be an array!
Indiegogo 1 All Categories (pr) ⚠️ DEBUG lib/FeedItem.php(217): Enclosures must be an array!
Indiegogo 2 Tech & Innovation (current) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): Innovation
Indiegogo 2 Tech & Innovation (pr) ❌ Bridge returned error 0! (19816)
❌ Type: Exception
❌ Message: Invalid parameters value(s): Innovation
Indiegogo 3 Creative Works (current) ⚠️ DEBUG lib/FeedItem.php(217): Enclosures must be an array!
Indiegogo 3 Creative Works (pr) ⚠️ DEBUG lib/FeedItem.php(217): Enclosures must be an array!
Indiegogo 4 Community Projects (current) ⚠️ DEBUG lib/FeedItem.php(217): Enclosures must be an array!
Indiegogo 4 Community Projects (pr) ⚠️ DEBUG lib/FeedItem.php(217): Enclosures must be an array!

last change: Wednesday 2024-04-03 18:18:56

dvikan commented 2 months ago

Perhaps you can contribute to https://github.com/RSS-Bridge/rss-bridge/issues/3991 since you now have gained some knowledge about url encoding