search

RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7.37k stars 1.04k forks source link

DemoBridge is missing in GitHub tarball/zip archive download #4281

Closed Mynacol closed 1 month ago

Mynacol commented 1 month ago

Describe the bug NixOS builds rss-bridge from the GitHub-generated tarball archive for the respective git tag. E.g. the latest release can be found at https://github.com/RSS-Bridge/rss-bridge/archive/refs/tags/2024-02-02.tar.gz. This archive, as well as the latest master zip at https://github.com/RSS-Bridge/rss-bridge/archive/refs/heads/master.zip and the tarball of the previous release at https://github.com/RSS-Bridge/rss-bridge/archive/refs/tags/2023-09-24.tar.gz all miss the bridges/DemoBridge.php file that is in the git repo (now and for years). I cannot explain why this file is missing, as the archive is autogenerated by GitHub from the git repo contents.

To Reproduce Steps to reproduce the behavior:

  1. Download one of the archives linked above (or pick another archive that should have the DemoBridge).
  2. Search for the DemoBridge.php file in the downloaded archive. It is not in the archive.
  3. Cross-check by cloning the git repo and checking out the same commit. There the DemoBridge.php file is available.

Expected behavior bridges/DemoBridge.php is in the archive files downloadable from GitHub.

Additional information The DemoBridge is nice to locally test the correct functioning of rss-bridge without depending on an internet connection. That's why I wanted to use it. The docker container seems to contain the file, but it is built by an action in this repo.

@dvikan can you look at this? If I see it right it is an issue with GitHub itself?

dvikan commented 1 month ago

Can confirm DemoBridge.php missing from zip archive. And it's a mystery why.

I checked .gitignore, not nothing there.

Bockiii commented 1 month ago

https://github.com/RSS-Bridge/rss-bridge/blob/80c43f10d83dcf4c0b9ff2707c6fe08fff8869ed/.gitattributes#L50

Mynacol commented 1 month ago

Thanks, that's the reason. I opened https://github.com/RSS-Bridge/rss-bridge/pull/4286 to stir up a discussion on this topic (either include this file in the tarball or remove it from the docker image)