search

RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7.37k stars 1.04k forks source link

Include all bridges in tarballs #4286

Closed Mynacol closed 1 month ago

Mynacol commented 1 month ago

Currently, two "demo" and "example" bridges are excluded from GitHub's autogenerated tarballs. As I argued, those files can still be helpful for integration tests, as they are run in NixOS and don't need internet access or depend on the availability of external services [1].

Additionally, the official docker image builds from the checkout so it includes those bridges when users use containers or a git checkout compared to tarballs. This commit therefore unifies the list of available bridges between deployment methods. Either we include those bridges in the tarball (preferred) or we exclude them from docker images as well.

[1] https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/web-apps/rss-bridge.nix#L20

Bockiii commented 1 month ago

Should be in the tarball, so remove them from the ignore-export list. Maybe @logmanoriginal still remembers why he removed them 5 years ago and if we are overlooking a reason.