RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7.36k stars 1.04k forks source link

[prtester] Rework test storage #4292

Closed Bockiii closed 1 month ago

Bockiii commented 1 month ago

This PR adapts the workflow and the prtester.py

The prtester.py will save the generated html files to the workflow executor instead of uploading it to the defunct termpad instance.

See #4269

The workflow adaption will upload those generated html files to a second repo, https://github.com/RSS-Bridge/rss-bridge-tests

The workflow will create a PR numbered folder in the /prs/ folder and store and update the files there in case a PR update is done.

The Workflow works in my personal repo setup:

To Do:

Bockiii commented 1 month ago

When you accept the PR, make extra sure to squash it so my 30 commits of developing this dont come in ^^

Bockiii commented 1 month ago

Hey, sorry overlooked the old URL and replaced it.

There is no "direct deployment to github pages", pages are always generated off a workflow made by github. The generation workflow takes place on the tests repo.

I'm not sure which jekyl building step you mean. You need to page deployment workflow for the files to be available under the github.io url. The link from you is talking about third party deployment pipelines, which we dont use. We are also not using or removing the /docs folder as the prs are in a /prs/ folder because I'm also planning to implement the long running process to do systematic "available bridge testing" and storing the results in that repo so it can also be viewed, see #2280

Mynacol commented 1 month ago

Hey, sorry overlooked the old URL and replaced it.

👍️

I'm not sure which jekyl building step you mean. You need to page deployment workflow for the files to be available under the github.io url. The link from you is talking about third party deployment pipelines, which we dont use. We are also not using or removing the /docs folder as the prs are in a /prs/ folder because [...]

The GitHub Action in rss-bridge-tests (here) has a "Build with Jekyll" step that I believe is inserted by default. As we just want to deploy the html files in the repo, we don't need this job at all. The (other) section in the github docs reads:

Alternatively, if GitHub Actions is unavailable or disabled, adding a .nojekyll file to the root of your source branch will bypass the Jekyll build process and deploy the content directly.

Bockiii commented 1 month ago

Added .nojekyll

Mynacol commented 1 month ago

Nice, and the newest action doesn't have the Jekyll build step 🎉 https://github.com/RSS-Bridge/rss-bridge-tests/actions/runs/11354640250/job/31582319945

Bockiii commented 1 month ago

To Do for @dvikan because hes the only person in the ownership team (which should be adapted, only 1 is a little risky)

Add a new repository secret "RSSTESTER_ACTION" and put in a PAT that has access to both org repos.

A PAT from dvikan should be enough at this point. Managing organizational tokens that are not account bound seems to be a bigger topic, outside of this PR.

dvikan commented 1 month ago

Made Bockiii an owner. @Bockiii