RSS-Bridge / rss-bridge

The RSS feed for websites missing it
https://rss-bridge.org/bridge01/
The Unlicense
7.36k stars 1.04k forks source link

phpunit tests are failing #4299

Closed Bockiii closed 1 month ago

Bockiii commented 1 month ago

hey @Mynacol @dvikan

The phpunit tests are failing and I have no earthly idea why. The tests were fine for a PR that changed a /docs/ document #4279 , were fine for a new bridge #4280 and then failed completely afterwards. I removed the bridge added in 4280 but the tests are still failing.

I dont understand the logs, please check and tell me how to fix that :D

Bockiii commented 1 month ago

For some reason this PR does not have issues: https://github.com/RSS-Bridge/rss-bridge/actions/runs/11205629407/job/31145376870

While this one (and all other new ones) have: https://github.com/RSS-Bridge/rss-bridge/actions/runs/11371042385/job/31632195668

Look at the "setup php" step. The second run has a redis warning. rssbridge doesnt have redis anywhere in the repo.

Is this an upstream issue somewhere?

I noticed that GH updated the ubuntu runner and that composer versions are higher now, but I assume that the setup-php step should fix that anyways:

https://github.com/actions/runner-images/blob/ubuntu20/20240922.1/images/ubuntu/Ubuntu2004-Readme.md https://github.com/actions/runner-images/blob/ubuntu20/20241006.1/images/ubuntu/Ubuntu2004-Readme.md

Bockiii commented 1 month ago

https://github.com/RSS-Bridge/rss-bridge/actions/runs/11370417349/job/31630151214

This run from an hour ago also had the latest ubuntu runner image and didnt have the warning, so ignore that through

Mynacol commented 1 month ago

I re-ran the actions for PR #4282 in https://github.com/RSS-Bridge/rss-bridge/actions/runs/11205629407/job/31636027479 and now that is failing too. I have no idea so far what's happening... The PHP Warning: Module 'redis' already loaded in Unknown on line 0 warning is indeed weird and might hint at the cause.

Bockiii commented 1 month ago

Someone opened the same issue in the setup-php repo just now. We are not alone ^^

Bockiii commented 1 month ago

Fixed in #4300