RSSNext / Follow

🧡 Follow your favorites in one inbox
https://follow.is
GNU General Public License v3.0
17.21k stars 714 forks source link

chore: update ja.json #1611

Closed dai closed 4 days ago

dai commented 1 week ago

chore: update app/ja.json and I tested local. // Can't wait for Monday.

This pull request includes updates to the Japanese localization file locales/app/ja.json. The changes primarily involve adding new achievement descriptions and updating the categories and descriptions in the discovery section.

Localization updates:

follow-reviewer-bot[bot] commented 1 week ago

Thank you for your contribution. We will review it promptly.

vercel[bot] commented 1 week ago

@dai is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

follow-reviewer-bot[bot] commented 1 week ago

Suggested PR Title:

feat(locales): add translations for new achievements and categories

Change Summary: Updated Japanese locale with new achievement and category translations, enhancing user experience and localization support.

Code Review:

Other than these minor phrasing issues, the rest of the changes look good.

Change requests necessary.

dai commented 1 week ago

Suggested PR Title:

feat(locales): add translations for new achievements and categories

Change Summary: Updated Japanese locale with new achievement and category translations, enhancing user experience and localization support.

Code Review:

  • File: locales/app/ja.json

    • Lines: 40-42

    • "discover.feed_description": "このフィードの説明は Follow で表示されます、またパラメータ フォームに関連する情報を記入することができます。"

    • The use of the conjunction "、" seems a bit off here. Consider changing "、また" to "。または" or splitting it into two sentences for better readability:

      "discover.feed_description": "このフィードの説明は Follow で表示されます。また、パラメータ フォームに関連する情報を記入することができます。",
    • Lines: 43-44

    • "discover.feed_maintainers": "フィードは RSSHub が提供し とともにクレジットされます。"

    • The phrasing seems incorrect. It might be clearer to phrase it as:

      "discover.feed_maintainers": "このフィードは RSSHub が提供しており、<maintainers /> と共にクレジットされています。",

Other than these minor phrasing issues, the rest of the changes look good.

Change requests necessary.

This review bot, you even proofread it😢

you left out a variable笑